Skip to content

docs(infinite-scroll): remove duplicate and unused imports #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2025

Conversation

kkindrai
Copy link
Contributor

@kkindrai kkindrai commented Jun 5, 2025

Resolves #4095

Changelog

  • Removed duplicate IonContent imports in Vue displays
  • Removed import and export of unused IonImg components in Vue displays
  • Demoed changes of modified components, all remain functional
  • Compiled and previewed modified docs site with changes, all remain functional

@kkindrai kkindrai requested a review from a team as a code owner June 5, 2025 23:48
Copy link

vercel bot commented Jun 5, 2025

@kkindrai is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2025 1:38pm

@brandyscarney brandyscarney changed the title Infinite scroll docs(infinite-scroll): remove duplicate imports Jun 6, 2025
@brandyscarney brandyscarney changed the title docs(infinite-scroll): remove duplicate imports docs(infinite-scroll): remove duplicate and unused imports Jun 6, 2025
@brandyscarney
Copy link
Member

This looks good! Please also remove the imports from the v7 examples:

IonContent,
IonContent,

@kkindrai
Copy link
Contributor Author

kkindrai commented Jun 6, 2025

Resolves #4095

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@brandyscarney brandyscarney merged commit 0c52a76 into ionic-team:main Jun 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content: Infinite scroll - Double IonContent import on the vue version
2 participants