-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(infinite-scroll): remove duplicate and unused imports #4138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested all examples with and without the import as mentioned in `https://github.com/ionic-team/ionic-docs/issues/4095`. Components maintain full functionality without this import.
@kkindrai is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This looks good! Please also remove the imports from the v7 examples: ionic-docs/static/usage/v7/infinite-scroll/basic/vue.md Lines 34 to 35 in 36ffb61
|
Resolves #4095
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Resolves #4095
Changelog